Add custom F3D and VTK alpine packages built by Manyfold project#20
Open
Floppy wants to merge 1 commit intolinuxserver:mainfrom
Open
Add custom F3D and VTK alpine packages built by Manyfold project#20Floppy wants to merge 1 commit intolinuxserver:mainfrom
Floppy wants to merge 1 commit intolinuxserver:mainfrom
Conversation
Collaborator
|
I am a bot, here are the test results for this PR:
|
Contributor
Author
|
I'm close to a 0.133.0 release now with this feature included; this PR will need merging before you release the next update - are you folks OK with it as-is, or should I change stuff? |
Contributor
Author
|
Ah crap, sorry, didn't think the 0.133.0 release would happen completely automatically, sorry. There might be some errors in https://github.com/linuxserver/docker-manyfold/releases/tag/v0.133.0-ls134 if people use the new renderer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest Manyfold code uses https://f3d.app for server-side image rendering. Because that's not yet included in Alpine, I've built my own packages which are being included in the official image (see https://github.com/manyfold3d/f3d-alpine).
I've submitted MRs to include/update the packages in Alpine proper, but obviously that takes time, so in the meantime, these packages work OK. They're built for Alpine 3.23, and if 3.24 appears before we get these into testing, I'll update them.
manyfold3d/manyfold#5493 is the equivalent PR to this for the official images.